Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format concept files added #2566

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Format concept files added #2566

wants to merge 3 commits into from

Conversation

PiotrNestor
Copy link
Contributor

@PiotrNestor PiotrNestor commented Jul 4, 2024 •
edited
Loading

@sriv
@zabil
Format concept files added ...
Resolves: #1509

Example: gauge format example.cpt

@PiotrNestor
Format also concepts
e229ef9 
Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
@PiotrNestor
Merge branch 'master' into format-concepts
9bd969b
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024 •
edited
Loading

Benchmark Results

java_maven_serial.csv

Commit CPU Memory Time ExitCode
aca081e 80% 251776 0:16.80 0
209816e 64% 262080 0:21.98 0
684d870 63% 205604 0:19.21 0
e09e2a5 72% 201080 0:17.18 0

java_simple_parallel.csv

Commit CPU Memory Time ExitCode
aca081e 23% 71632 0:23.81 0
209816e 22% 74208 0:25.02 0
684d870 22% 75992 0:24.47 0
e09e2a5 23% 71696 0:24.34 0

java_simple_multithreaded.csv

Commit CPU Memory Time ExitCode
aca081e 29% 71592 0:12.17 0
209816e 28% 70148 0:12.10 0
684d870 34% 68012 0:10.56 0
e09e2a5 31% 67624 0:11.73 0

java_simple_serial.csv

Commit CPU Memory Time ExitCode
aca081e 42% 65592 0:14.32 0
209816e 44% 67716 0:14.15 0
684d870 53% 67684 0:11.47 0
e09e2a5 50% 69804 0:12.33 0

java_maven_parallel.csv

Commit CPU Memory Time ExitCode
aca081e 45% 248244 0:30.68 0
209816e 40% 218564 0:34.92 0
684d870 33% 177512 0:34.73 0
e09e2a5 34% 187900 0:33.65 0

java_gradle_multithreaded.csv

Commit CPU Memory Time ExitCode
aca081e 9% 116704 0:23.63 0
209816e 10% 122740 0:22.51 0
684d870 10% 123668 0:24.49 0
e09e2a5 11% 132720 0:22.88 0

java_maven_multithreaded.csv

Commit CPU Memory Time ExitCode
aca081e 63% 234180 0:18.12 0
209816e 59% 210032 0:19.35 0
684d870 58% 183140 0:15.71 0
e09e2a5 59% 168880 0:15.68 0

java_gradle_parallel.csv

Commit CPU Memory Time ExitCode
aca081e 5% 121208 0:40.88 0
209816e 5% 128988 0:46.76 0
684d870 5% 116480 0:45.44 0
e09e2a5 5% 99472 0:46.16 0

java_gradle_serial.csv

Commit CPU Memory Time ExitCode
aca081e 9% 111040 0:24.87 0
209816e 10% 126456 0:25.35 0
684d870 10% 130832 0:25.82 0
e09e2a5 9% 117040 0:25.64 0

Notes

  • The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
  • These results are not persisted, but on merging to master the benchmark will be rerun.
  • These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

See Workflow log for more details.

@PiotrNestor
Added error management for FormatConceptFilesIn
4171a21 
Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
@gaugebot
Copy link

gaugebot bot commented Jul 4, 2024

@PiotrNestor Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@haroon-sheikh haroon-sheikh marked this pull request as ready for review July 4, 2024 20:18
haroon-sheikh
haroon-sheikh reviewed Aug 15, 2024
View reviewed changes
version/version.go
@@ -14,7 +14,7 @@ import (
)

// CurrentGaugeVersion represents the current version of Gauge
var CurrentGaugeVersion = &Version{1, 6, 7}
var CurrentGaugeVersion = &Version{1, 6, 8}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var CurrentGaugeVersion = &Version{1, 6, 8}
var CurrentGaugeVersion = &Version{1, 6, 9}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haroon-sheikh haroon-sheikh haroon-sheikh approved these changes

@sriv sriv sriv approved these changes

Assignees
No one assigned
Labels
ReleaseCandidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gauge format does not format concept files
3 participants
@PiotrNestor @sriv @haroon-sheikh